[ETCM-716] Readd block headers to work queue in case of errors #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…header work queue to sync state
1015bit
commented
Mar 19, 2021
| @@ -677,17 +680,16 @@ class FastSync( | |||
| private def handleRequestFailure(peer: Peer, handler: ActorRef, reason: BlacklistReason): Unit = { | |||
| removeRequestHandler(handler) | |||
|
|
|||
| requestedHeaders.get(peer).foreach(requested => syncState = syncState.enqueueHeaderRange(requested)) | |||
There was a problem hiding this comment.
This is the relevant line for fixing the bug.
robinraju
approved these changes
Mar 19, 2021
dzajkowski
approved these changes
Mar 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
syncStateto keep it together with the work queues for bodies and receiptsProposed Solution
If requests time out or the peer disconnects we need to readd the requested block headers to the work queue so they will be requested from another peer.
Testing
Full sync on sagano testnet and successful syncing on mainnet for some time.