Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETCM-720: Added tests for mining block on beginning or end of epoch #950

Merged
merged 1 commit into from
Mar 24, 2021

Conversation

milenkara
Copy link
Contributor

Description

Added tests for mining first and last block of an epoch.

Testing

In order to validate my changes, I have temporarily reverted @pbvie's changes and the test were failing when generating the last block of the epoch. With the new changes mining tests are passing.

Additional note: I noticed that in the build.sbt miner tests (EthashMinerSpec ) are excluded. I have changed this during development, but didn't include it in the PR.

@milenkara milenkara force-pushed the ETCM-720-tests-for-mining-in-epoch branch 4 times, most recently from b588fe3 to 76038e8 Compare March 24, 2021 18:04
@milenkara milenkara force-pushed the ETCM-720-tests-for-mining-in-epoch branch from 76038e8 to bce338c Compare March 24, 2021 19:10
@milenkara milenkara merged commit afb6114 into develop Mar 24, 2021
@milenkara milenkara deleted the ETCM-720-tests-for-mining-in-epoch branch March 24, 2021 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants