-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix the update-nix script #954
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonringer
approved these changes
Mar 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
1015bit
approved these changes
Mar 26, 2021
jonringer
reviewed
Mar 26, 2021
manveru
commented
Mar 27, 2021
manveru
force-pushed
the
fix-update-nix
branch
5 times, most recently
from
March 31, 2021 08:21
3037c96
to
9514770
Compare
infinisil
approved these changes
Mar 31, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
1015bit
approved these changes
Mar 31, 2021
bsuieric
pushed a commit
that referenced
this pull request
Apr 13, 2021
* fix the update-nix script * insert mantis-extvm-pb into the build instead of using submodules * disable darwin builds because solc fails * rely on depsSha256 instead of a hack * another try to fix hash generation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A clear and concise description of what this pull request does or fixes.
Proposed Solution
Optional Explain how does this PR solves the problem stated in Description. You can also enumerate different alternatives considered while approaching this task.
Important Changes Introduced
Optional Notice Reviewers about changes that were introduced while developing this task
Testing
Optional Leave some recommendations should be useful while reviewers are testing this PR