-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ETCM-680 retesteth in Nix and on CI #965
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pment, also simplifies dist mapping a bit
Signed-off-by: Igor Grahovac <igor.grahovac@iohk.io>
…cording to eth spec for retesteth. Fixed genesis loading for regular node
…null fields in JSON response, add coinbase field to BlockResponse
…nature fields required by retesteth
…d storing of contract codes and storage data
jvdp
force-pushed
the
feature/ETCM-680-retesteth-ci
branch
from
April 16, 2021 14:23
e51ad47
to
88b1e79
Compare
jvdp
force-pushed
the
feature/ETCM-680-retesteth-ci
branch
from
April 19, 2021 19:05
de21f15
to
e341ebf
Compare
jvdp
force-pushed
the
feature/ETCM-680-retesteth-ci
branch
from
April 20, 2021 07:24
e341ebf
to
d664273
Compare
jvdp
changed the title
ETCM-680 retesteth in nix WIP
ETCM-680 retesteth in Nix and on CI
Apr 20, 2021
dzajkowski
reviewed
Apr 20, 2021
dzajkowski
reviewed
Apr 20, 2021
dzajkowski
reviewed
Apr 20, 2021
dzajkowski
reviewed
Apr 20, 2021
dzajkowski
reviewed
Apr 20, 2021
dzajkowski
reviewed
Apr 20, 2021
dzajkowski
approved these changes
Apr 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. maybe @nrdxp could give this a look?
jonringer
reviewed
Apr 20, 2021
bsuieric
approved these changes
Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the custom ETS implementation by retesteth, installed via Nix.
The new readme describes how to use it: https://github.com/input-output-hk/mantis/blob/feature/ETCM-680-retesteth-ci/ets/README.md (Also have a look at buildkite for annotations and output.)