Bug/etcm 797 #974
Merged
Bug/etcm 797 #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsuieric
commented
Apr 26, 2021
bsuieric
commented
Apr 26, 2021
… from connected peers
jvdp
approved these changes
Apr 26, 2021
dzajkowski
reviewed
Apr 26, 2021
src/main/scala/io/iohk/ethereum/consensus/pow/EthashUtils.scala
Outdated
Show resolved
Hide resolved
dzajkowski
reviewed
Apr 26, 2021
src/main/scala/io/iohk/ethereum/consensus/pow/EthashDAGManager.scala
Outdated
Show resolved
Hide resolved
dzajkowski
reviewed
Apr 26, 2021
src/main/scala/io/iohk/ethereum/jsonrpc/DebugJsonMethodsImplicits.scala
Outdated
Show resolved
Hide resolved
dzajkowski
reviewed
Apr 26, 2021
| val seedEpoch0 = ByteStringUtils.string2hash("0000000000000000000000000000000000000000000000000000000000000000") | ||
| val seedEpoch1 = ByteStringUtils.string2hash("290decd9548b62a8d60345a988386fc84ba6bc95484008f6362f93160ef3e563") | ||
| val seedEpoch382 = ByteStringUtils.string2hash("d3d0aa11197dcdcfcb3ad3c73d415af47299bddb47fda6081d31d9dd06462f6a") | ||
| val seedEpoch383 = ByteStringUtils.string2hash("bf532874eb434842e7a3e4acd113fe454541651872760d9b95d11d7f90ca25dc") |
There was a problem hiding this comment.
where did these hashes come from? maybe this would be a good inspiration https://github.com/iquidus/ecip-1099-data ?
There was a problem hiding this comment.
These are the seeds that correspond to the blocks, calculated with the Mantis code found to be working properly (valid blocks are valid.)
But the strings themselves are not so interesting for the purposes of this bug, just that they are the same across different blocks within a (ECIP-1099) epoch. (For the implementation itself the hashes are important of course.)
There was a problem hiding this comment.
(Also, the hash being all zeroes for epoch 0 is a good sign?)
dzajkowski
requested changes
Apr 26, 2021
added 3 commits
April 26, 2021 17:59
… number) from connected peers" This reverts commit 48b39b5.
dzajkowski
approved these changes
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://jira.iohk.io/browse/ETCM-797
Proposed Solution
calculate start epoch block, and calculate seed based on the epoch length and start epoch block