Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCP-4908: Add the Escrow to the examples suite #163

Merged
merged 7 commits into from
Mar 8, 2023
Merged

SCP-4908: Add the Escrow to the examples suite #163

merged 7 commits into from
Mar 8, 2023

Conversation

yveshauser
Copy link
Member

@yveshauser yveshauser commented Mar 1, 2023 •
edited
Loading

This PR adds

  • the Escrow example to Isabelle
  • and the generated specification
  • Unit tests for all possible outcomes of the contract to the test-spec

@yveshauser yveshauser self-assigned this Mar 1, 2023
@yveshauser yveshauser marked this pull request as ready for review March 7, 2023 08:30
@yveshauser yveshauser requested a review from hrajchert March 7, 2023 08:35
hrajchert
hrajchert approved these changes Mar 7, 2023
View reviewed changes
Copy link
Collaborator

@hrajchert hrajchert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌
Minor changes suggested

isabelle/CodeExports/CodeExports.thy Outdated Show resolved Hide resolved
isabelle/Examples/Escrow.thy Outdated Show resolved Hide resolved
isabelle/Examples/Escrow.thy Outdated Show resolved Hide resolved
isabelle/Examples/Escrow.thy Outdated Show resolved Hide resolved
isabelle/Examples/Escrow.thy Show resolved Hide resolved
marlowe-spec-test/src/Marlowe/Spec/Core/Examples/Escrow.hs Show resolved Hide resolved
yveshauser and others added 3 commits March 8, 2023 09:21
@yveshauser @hrajchert
Update isabelle/Examples/Escrow.thy
5cdc622 
Co-authored-by: Hernan Rajchert <hrajchert@gmail.com>
@yveshauser @hrajchert
Update isabelle/Examples/Escrow.thy
23d7950 
Co-authored-by: Hernan Rajchert <hrajchert@gmail.com>
@yveshauser
PLT-4142: Added new lines (review feed-back)
f193efc
@yveshauser yveshauser merged commit 8f5c4ea into master Mar 8, 2023
@yveshauser yveshauser deleted the SCP-4908 branch March 8, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hrajchert hrajchert hrajchert approved these changes

Assignees

@yveshauser yveshauser

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yveshauser @hrajchert