Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warning log when building OpenAPI UI in CI #2017

Closed
1 task done
Alenar opened this issue Oct 18, 2024 · 0 comments
Closed
1 task done

Fix warning log when building OpenAPI UI in CI #2017

Alenar opened this issue Oct 18, 2024 · 0 comments
Assignees
@Alenar
Labels
optimization 🛠️ Optimization and/or small enhancements

Comments

@Alenar
Copy link
Collaborator

Alenar commented Oct 18, 2024 •
edited
Loading

Why

We are passing a incorrect parameter to the Legion2/swagger-ui-action@v1 action resulting in warnings in our ci workflows:
https://github.com/input-output-hk/mithril/actions/runs/11347281527/job/31558291126#step:3:1

What

We want to use our github token to have an increased rate limit, to do so we pass a token parameter to the Legion2/swagger-ui-action@v1 but the expected parameter name is GITHUB_TOKEN.

How

  • Fix github token parameter when using Legion2/swagger-ui-action@v1 action
@Alenar Alenar self-assigned this Oct 18, 2024
@jpraynaud jpraynaud added the optimization 🛠️ Optimization and/or small enhancements label Oct 18, 2024
Alenar added a commit that referenced this issue Oct 18, 2024
@Alenar
fix(ci): use correct name for github token when building openapi ui
d797d46 
Refs: #2017
@Alenar Alenar mentioned this issue Oct 18, 2024
Merged
6 tasks
@Alenar Alenar closed this as completed Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Alenar Alenar

Labels
optimization 🛠️ Optimization and/or small enhancements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Alenar @jpraynaud