Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependency-review check when merging to main #1054

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

Alenar
Copy link
Collaborator

@Alenar Alenar commented Jul 12, 2023

Content

This PR fix the dependency review action when merging PR on the main branch by providing the arguments that this action ask when running on something else than a pull_request action trigger.

Pre-submit checklist

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • Useful pull request description
    • Reviewer requested

Issue(s)

Relates to #1037

@Alenar Alenar requested review from jpraynaud and ghubertpalo July 12, 2023 08:20
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions
Copy link

github-actions bot commented Jul 12, 2023

Test Results

    3 files  ±0    16 suites  ±0   5m 30s ⏱️ - 1m 6s
616 tests ±0  616 ✔️ ±0  0 💤 ±0  0 ±0 
654 runs  ±0  654 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 4bfbe0b. ± Comparison against base commit b8cc787.

♻️ This comment has been updated with latest results.

@Alenar Alenar temporarily deployed to testing-preview July 12, 2023 08:27 — with GitHub Actions Inactive
@Alenar Alenar force-pushed the djo/1037/bug/fix-dependency-review-working-only-on-pr branch from 0829221 to 4bfbe0b Compare July 12, 2023 08:30
@Alenar Alenar temporarily deployed to testing-preview July 12, 2023 08:38 — with GitHub Actions Inactive
@Alenar Alenar merged commit 311829e into main Jul 12, 2023
@Alenar Alenar deleted the djo/1037/bug/fix-dependency-review-working-only-on-pr branch July 12, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants