Speedup node bootstrap after client download #1132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alenar
force-pushed
the
djo/1131/speedup-node-bootstrap-after-client-download
branch
from
c32573e to
ed64fea
Compare
Alenar
force-pushed
the
djo/1131/speedup-node-bootstrap-after-client-download
branch
from
3580289 to
bc0941a
Compare
ghost
reviewed
Aug 3, 2023
| } | ||
|
|
||
| #[tokio::test] | ||
| async fn test_download_snapshot_ok_add_clean_file_allowing_node_bootstrap_speedup() { |
There was a problem hiding this comment.
Do we have a test checking not adding the 'clean' file still works? I was under the impression the could would always try to create it.
There was a problem hiding this comment.
I would be nice bust costly , to do that cleanly I need to extract the code that insert the clean file in a separated service to mock it. For such a small part I don't think that's worth the increased complexity.
Alenar
force-pushed
the
djo/1131/speedup-node-bootstrap-after-client-download
branch
from
bc0941a to
a6b0073
Compare
Alenar
deleted the
djo/1131/speedup-node-bootstrap-after-client-download
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR make the
snapshot downloadcommand of the client append a empty file named 'clean' in the unpacked database.This is a trick to tell the cardano node to skip the ledger check at startup (this file is usually added by the node itself on a clean shutdown).
Pre-submit checklist
Issue(s)
Relates to #1131