Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add snapshot archive verification #1138

Merged
merged 3 commits into from
Aug 8, 2023

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Aug 7, 2023

Content

This PR includes a fix for the aggregator producing from time to time corrupted archives: the created snapshot archive is verified before being published. This is a quick term fix, and a new implementation of the snapshot production will be done shortly.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Closes #1137

@jpraynaud jpraynaud self-assigned this Aug 7, 2023
@jpraynaud jpraynaud requested a review from Alenar August 7, 2023 15:16
@github-actions
Copy link

github-actions bot commented Aug 7, 2023

Test Results

    3 files  ±0    16 suites  ±0   5m 26s ⏱️ - 1m 10s
656 tests +1  656 ✔️ +1  0 💤 ±0  0 ±0 
696 runs  +1  696 ✔️ +1  0 💤 ±0  0 ±0 

Results for commit 5da42ac. ± Comparison against base commit 9a1e80d.

@jpraynaud jpraynaud temporarily deployed to testing-preview August 7, 2023 15:33 — with GitHub Actions Inactive
@jpraynaud jpraynaud merged commit 137b56c into main Aug 8, 2023
@jpraynaud jpraynaud deleted the jpraynaud/1137-fix-snapshot-archive branch August 8, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client fails to unpack some snapshot archive
2 participants