Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disk space warning not displayed in client #1192

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Aug 30, 2023

Content

This PR includes a fix that prevented the display of the warning message when the available space on the disk might not be sufficient. The message was displayed only if verbose output (-v) was specified.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Relates to #1160

@github-actions
Copy link

Test Results

    3 files  ±0    17 suites  ±0   5m 18s ⏱️ +47s
671 tests ±0  671 ✔️ ±0  0 💤 ±0  0 ±0 
727 runs  ±0  727 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit c7af44c. ± Comparison against base commit 9630459.

@jpraynaud jpraynaud temporarily deployed to testing-preview August 30, 2023 17:10 — with GitHub Actions Inactive
@jpraynaud jpraynaud merged commit 3673209 into main Aug 31, 2023
@jpraynaud jpraynaud deleted the jpraynaud/1160-fix-disk-space-warning-client branch August 31, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants