-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Mithril Threat Model
page on website
#1726
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some typo issues on my side
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here the assets are enumerated, but there is no analysis of the associated risks, neither the mitigations. Am I misunderstanding the scope of the document?
|
||
* **availability**: No (? The key is not needed unless a re-genesis process is required, but then a new key could be used instead?) | ||
* **confidentiality**: Yes | ||
* **integrity**: Yes (?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we say Genesis signing keys are tamper-proof?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@curiecrypt could you make a suggestion for this comment?
(I think that it will also apply to the "Era signing key" section)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
System description contains most important things, but is a bit inconsistent on libp2p or not.
Assets already a good collection. We should order the CIA items consistently though.
Threats are clearly not complete. Probably can't hurt to also mention there that this is incomplete.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to be clear: I do approve of this document. "Done is better than perfect" and anything we can get published about this is good.
There are many good comments by reviewers which, when incorporated, makes this even better.
From Hackmd draft: https://hackmd.io/KTJnHKhjT1eNj4IrrtxrOA Co-authored-by: Arnaud Bailly <arnaud.bailly@iohk.io>
f051325
to
8582843
Compare
Content
This PR includes a new Mithril Threat Model page on the website based on the original Hackmd document:
Tip
In order to run locally the website, please run the following steps:
cd docs/website
from the root of the repositorynpm install
make dev
Pre-submit checklist
Issue(s)
Closes #1350