Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Cardano node 8.12.2 #1788

Merged
merged 15 commits into from
Jul 2, 2024
Merged

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Jun 27, 2024

Content

This PR includes the support for Cardano node 8.12.2.

Warning

The version of the Cardano node must be updated in the GitHub environment variable CARDANO_NODE_VERSION to 8.12.2 for testing-preview and 8.12.0-pre for testing-sanchonet prior merge of this PR.

Pre-submit checklist

  • Branch
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Comments

When trying to run the Cardano node 8.12 in the devnet starting with the Babbage era, a bug prevents the creation of transactions with the Cardano cli with the following error:

cardano-cli: DecoderFailure (LocalStateQuery HardForkBlock (': * ByronBlock (': * (ShelleyBlock (TPraos StandardCrypto) (ShelleyEra StandardCrypto)) (': * (ShelleyBlock (TPraos StandardCrypto) (AllegraEra StandardCrypto)) (': * (ShelleyBlock (TPraos StandardCrypto) (MaryEra StandardCrypto)) (': * (ShelleyBlock (TPraos StandardCrypto) (AlonzoEra StandardCrypto)) (': * (ShelleyBlock (Praos StandardCrypto) (BabbageEra StandardCrypto)) (': * (ShelleyBlock (Praos StandardCrypto) (ConwayEra StandardCrypto)) ('[] *)))))))) Query (BlockQuery (HardForkBlock (': * ByronBlock (': * (ShelleyBlock (TPraos StandardCrypto) (ShelleyEra StandardCrypto)) (': * (ShelleyBlock (TPraos StandardCrypto) (AllegraEra StandardCrypto)) (': * (ShelleyBlock (TPraos StandardCrypto) (MaryEra StandardCrypto)) (': * (ShelleyBlock (TPraos StandardCrypto) (AlonzoEra StandardCrypto)) (': * (ShelleyBlock (Praos StandardCrypto) (BabbageEra StandardCrypto)) (': * (ShelleyBlock (Praos StandardCrypto) (ConwayEra StandardCrypto)) ('[] *))))))))))) ServerAgency TokQuerying BlockQuery (QueryIfCurrent (QS (QS (QS (QS (QS (QZ GetCurrentPParams)))))))) (DeserialiseFailure 995 "Expected array with 175 entries, but encoded array has 185 entries.")Error: Write era marker on chain exited with status code: 1

This is a known issue and there is a PR attempting to fix the problem in the Cardano cli repository: IntersectMBO/cardano-api#564

Issue(s)

Relates to #1787

@jpraynaud jpraynaud self-assigned this Jun 27, 2024
Copy link

github-actions bot commented Jun 27, 2024

Test Results

    4 files  ±0     51 suites  ±0   8m 48s ⏱️ -3s
1 114 tests ±0  1 114 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 262 runs  ±0  1 262 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit bd2604a. ± Comparison against base commit 36f9f4c.

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud force-pushed the jpraynaud/support-cardano-node-8.12.1 branch from f2d2923 to 4a0e524 Compare June 28, 2024 13:46
@jpraynaud jpraynaud temporarily deployed to testing-preview June 28, 2024 15:35 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet June 28, 2024 15:35 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/support-cardano-node-8.12.1 branch from a8fee6e to 5796e15 Compare July 2, 2024 13:19
@jpraynaud jpraynaud changed the title Support Cardano node 8.12.1 Support Cardano node 8.12.2 Jul 2, 2024
@jpraynaud jpraynaud requested review from Alenar, sfauvel and dlachaume July 2, 2024 13:26
@jpraynaud jpraynaud temporarily deployed to testing-preview July 2, 2024 13:28 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet July 2, 2024 13:28 — with GitHub Actions Inactive
jpraynaud added 15 commits July 2, 2024 17:19
Cardano node '8.12' has a bug that prevents it from creating
transactions when it is started with the Babbage era.

The error is due to the addition of parameters to the PlutusV2 cost
model which creates an error when creating a transaction with
the cardano-cli. This is a known issue that should be fixed with the next
release.
- 'mithril-aggregator' from '0.5.33' to '0.5.34'
- 'mithril-infra' from '0.2.19' to '0.2.20'
- 'mithril-signer' from '0.2.156' to '0.2.157'
- 'mithril-devnet' from '0.3.6' to '0.3.7'
- 'mithril-end-to-end' from '0.4.19' to '0.4.20'.
@jpraynaud jpraynaud force-pushed the jpraynaud/support-cardano-node-8.12.1 branch from 5796e15 to bd2604a Compare July 2, 2024 15:20
@jpraynaud jpraynaud temporarily deployed to testing-preview July 2, 2024 15:28 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet July 2, 2024 15:28 — with GitHub Actions Inactive
@jpraynaud jpraynaud merged commit e67c830 into main Jul 2, 2024
39 of 40 checks passed
@jpraynaud jpraynaud deleted the jpraynaud/support-cardano-node-8.12.1 branch July 2, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants