fix: ChainReader fails on find_intersect_point without agency
#1852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpraynaud
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
jpraynaud
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
falcucci
reviewed
Jul 23, 2024
falcucci
approved these changes
Jul 23, 2024
When the chain sync client does not have agency (i.e. is waiting for the server to callback), the find intersect point triggered is not allowed and is now skipped.
jpraynaud
force-pushed
the
jpraynaud/1836-fix-chain-reader-stuck-error
branch
from
08f1a36 to
eda8aa5
Compare
jpraynaud
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
jpraynaud
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
dlachaume
approved these changes
Jul 24, 2024
Rollback value from '15' to '1'.
- 'mithril-common' from '0.4.34' to '0.4.35'.
jpraynaud
force-pushed
the
jpraynaud/1836-fix-chain-reader-stuck-error
branch
from
eda8aa5 to
8f88564
Compare
jpraynaud
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
jpraynaud
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
sfauvel
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR includes a fix to the Chain Reader:
when the Chain Sync client does not have agency (i.e. is waiting for the server to callback), the find intersect point call to the Chain Sync is not allowed and is now skipped in the
find_intersect_pointfunction of the Chain Reader.Pre-submit checklist
Issue(s)
Closes #1836