Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase timeout for client WASM headless browser tests #1864

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Increase timeout for client WASM headless browser tests #1864

merged 1 commit into from
Jul 29, 2024

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Jul 29, 2024 •
edited
Loading

Content

This PR includes a modification to the timeout for the client WASM headless browser tests (executed by Mithril Client multi-platform test).

Since certificate chain verification takes longer on preview than on sanchonet, the timeout has been increased from 3 minutes to 10 minutes.

Mithril Client multi-platform test results:
https://github.com/input-output-hk/mithril/actions/runs/10141858789/job/28039918080

Pre-submit checklist

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@dlachaume dlachaume self-assigned this Jul 29, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 29, 2024 •
edited
Loading

Test Results

    4 files  ±0     52 suites  ±0   9m 14s ⏱️ -5s
1 191 tests ±0  1 191 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 357 runs  ±0  1 357 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit f51aa21. ± Comparison against base commit eaaa3dd.

♻️ This comment has been updated with latest results.

@dlachaume dlachaume temporarily deployed to testing-preview July 29, 2024 09:14 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet July 29, 2024 09:14 — with GitHub Actions Inactive
@dlachaume dlachaume force-pushed the dlachaume/increase-headless-tests-timeout branch from 6814e6b to 25b966e Compare July 29, 2024 09:28
@dlachaume dlachaume temporarily deployed to testing-preview July 29, 2024 09:35 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet July 29, 2024 09:35 — with GitHub Actions Inactive
@dlachaume dlachaume requested review from sfauvel and jpraynaud July 29, 2024 09:46
@dlachaume dlachaume marked this pull request as ready for review July 29, 2024 09:47
@dlachaume dlachaume force-pushed the dlachaume/increase-headless-tests-timeout branch from 25b966e to f51aa21 Compare July 29, 2024 12:52
@dlachaume dlachaume temporarily deployed to testing-sanchonet July 29, 2024 13:06 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-preview July 29, 2024 13:09 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet July 29, 2024 13:09 — with GitHub Actions Inactive
@dlachaume dlachaume merged commit 330bd85 into main Jul 29, 2024
40 checks passed
@dlachaume dlachaume deleted the dlachaume/increase-headless-tests-timeout branch July 29, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpraynaud jpraynaud jpraynaud approved these changes

@sfauvel sfauvel Awaiting requested review from sfauvel

Assignees

@dlachaume dlachaume

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dlachaume @jpraynaud