Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev blog post for Cardano transaction certification feature roll-out #1868

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Dev blog post for Cardano transaction certification feature roll-out #1868

merged 1 commit into from
Jul 30, 2024

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Jul 30, 2024 •
edited
Loading

Content

This PR includes a new dev blog post about the progressive roll out of the Cardano transaction certification in the Mithril networks.

Pre-submit checklist

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Add dev blog post (if relevant)

Issue(s)

Relates to #1830

@jpraynaud jpraynaud self-assigned this Jul 30, 2024
@jpraynaud jpraynaud requested review from sfauvel and dlachaume July 30, 2024 10:12
sfauvel
sfauvel approved these changes Jul 30, 2024
View reviewed changes
Copy link
Collaborator

@sfauvel sfauvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 30, 2024 •
edited
Loading

Test Results

    4 files  ±0     52 suites  ±0   9m 13s ⏱️ -7s
1 191 tests ±0  1 191 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 357 runs  ±0  1 357 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit f74f8dd. ± Comparison against base commit a6e712a.

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud force-pushed the jpraynaud/1830-dev-blog-post-cardano-transaction branch from 84638c9 to f74f8dd Compare July 30, 2024 10:28
@jpraynaud jpraynaud temporarily deployed to testing-preview July 30, 2024 11:02 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet July 30, 2024 11:02 — with GitHub Actions Inactive
@jpraynaud jpraynaud merged commit b4ac654 into main Jul 30, 2024
43 of 44 checks passed
@jpraynaud jpraynaud deleted the jpraynaud/1830-dev-blog-post-cardano-transaction branch July 30, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlachaume dlachaume dlachaume approved these changes

@sfauvel sfauvel sfauvel approved these changes

Assignees

@jpraynaud jpraynaud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpraynaud @sfauvel @dlachaume