Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monitor Mithril nodes footprint #1871

Merged
merged 4 commits into from
Jul 31, 2024
Merged

Monitor Mithril nodes footprint #1871

merged 4 commits into from
Jul 31, 2024

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Jul 30, 2024 •
edited
Loading

Content

This PR includes improvements to the monitoring of the Mithril nodes to benchmark their full footprint:

  • Monitoring of the Mithril nodes resources (CPU, memory)
  • Monitoring of the Mithril aggregator and signer disk usage

Pre-submit checklist

  • Branch
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Relates to #1826

@jpraynaud jpraynaud self-assigned this Jul 30, 2024
@jpraynaud jpraynaud requested review from sfauvel and dlachaume July 30, 2024 16:25
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 30, 2024 •
edited
Loading

Test Results

    4 files  ±0     52 suites  ±0   9m 6s ⏱️ -9s
1 191 tests ±0  1 191 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 357 runs  ±0  1 357 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 35ef708. ± Comparison against base commit ffc6dc2.

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud temporarily deployed to testing-preview July 30, 2024 16:33 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet July 30, 2024 16:33 — with GitHub Actions Inactive
sfauvel
sfauvel approved these changes Jul 31, 2024
View reviewed changes
Copy link
Collaborator

@sfauvel sfauvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dlachaume
dlachaume approved these changes Jul 31, 2024
View reviewed changes
Copy link
Collaborator

@dlachaume dlachaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍.
Just a question and a typo to fix

mithril-infra/assets/docker/prometheus/disk_usage_exporter/Dockerfile Outdated Show resolved Hide resolved
mithril-infra/assets/docker/docker-compose-monitoring.yaml Outdated Show resolved Hide resolved
@jpraynaud jpraynaud force-pushed the jpraynaud/1826-mithril-nodes-footprint branch from c6cdc95 to 35ef708 Compare July 31, 2024 08:49
@jpraynaud jpraynaud temporarily deployed to testing-preview July 31, 2024 08:57 — with GitHub Actions Inactive
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet July 31, 2024 08:57 — with GitHub Actions Inactive
@jpraynaud jpraynaud merged commit 7a7396e into main Jul 31, 2024
40 of 41 checks passed
@jpraynaud jpraynaud deleted the jpraynaud/1826-mithril-nodes-footprint branch July 31, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlachaume dlachaume dlachaume approved these changes

@sfauvel sfauvel sfauvel approved these changes

Assignees

@jpraynaud jpraynaud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpraynaud @sfauvel @dlachaume