Fix: ChainReaderBlockStreamer skips RollForward blocks at the tip
#1877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 4 files ±0 52 suites ±0 9m 4s ⏱️ ±0s Results for commit 9ce7ab3. ± Comparison against base commit 693ea4c. This pull request removes 1 and adds 2 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
jpraynaud
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
jpraynaud
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
dlachaume
approved these changes
Aug 1, 2024
…ove the limit In the Chain Reader Block Streamer, the Chain Reader reads the block strictly above the threshold instead of stopping as soon as the threshold is reached. When the Chain Reader is at the tip of the chain, the underlying chain sync client switches agency and it can not find a new intersection then. The result is that the block which was read too early was never recorded in the store, which caused a wrong computation of some of the block range roots and thus of the protocol message.
- 'mithril-common' from '0.4.41' to '0.4.42'.
jpraynaud
force-pushed
the
ensemble/1875-fix-edge-case-chain-reader-block-streamer
branch
from
c2dceb5 to
9ce7ab3
Compare
jpraynaud
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
jpraynaud
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
jpraynaud
deleted the
ensemble/1875-fix-edge-case-chain-reader-block-streamer
branch
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR includes a fix to the
ChainReaderBlockStreamerwhich skipsRollForwardblocks at the tip of the chain.Pre-submit checklist
Issue(s)
Closes #1875