feat: support file:// URLs for snapshot locations

[michalrus]

LW-11112

Content

This PR includes support for the file:// scheme in URLs of the snapshots.

This is very useful for live demos, where you don’t want to repeatedly download from Google Cloud Storage because of the wait time and cost.

Pre-submit checklist

• Branch
  • Tests are provided (if possible)
  • Crates versions are updated (if relevant)
  • CHANGELOG file is updated (if relevant)
  • Commit sequence broadly makes sense
  • Key commits have useful messages
• PR
  • No clippy warnings in the CI
  • Self-reviewed the diff
  • Useful pull request description
  • Reviewer requested
• Documentation
  • Update README file (if relevant)
  • Update documentation website (if relevant)
  • Add dev blog post (if relevant)

Comments

It requires a proxy modifying responses from the aggregator, e.g. this.

Issue(s)

LW-11112

[Alenar]

Looks good, good work 🚀.

I've left a few suggestions below.

[michalrus]

Thanks for the positive reviews! 😃 I will try to update it today ⏳

[michalrus]

@jpraynaud, @Alenar, I followed your suggestions, but I'm not sure why the macos-14 job failed? No log, but since macos-12 worked, it might be enough to just restart it, but I don't have the necessary privileges.

[jpraynaud]

@jpraynaud, @Alenar, I followed your suggestions, but I'm not sure why the macos-14 job failed? No log, but since macos-12 worked, it might be enough to just restart it, but I don't have the necessary privileges.

Apparently the jobs failed to start @michalrus, I just restarted them 👍

[jpraynaud]

LGTM 🚀

Thanks for the contribution @michalrus!

Can you update the CHANGELOG and bump the mithril-client patch version before we can merge your PR?

[michalrus]

Thank you!

Can you update the CHANGELOG and bump the mithril-client patch version before we can merge your PR?

Done in ecb9af3. I also had to rebase onto the current main.

[michalrus]

Oh, sorry, I didn't update the Cargo.lock 🤦 ⏳

Edit: done (diff).

[michalrus]

For some reason ci/hydra-build:x86_64-darwin.mithril-signer is failing:

     Running `/private/tmp/nix-build-mithril-signer-0.2.173.drv-0/source/target/release/deps/mithril_signer-ffb4edaeea67228b`
<jemalloc>: Error allocating TSD
error: test failed, to rerun pass `-p mithril-signer --lib`

I have restarted the evaluation.

[michalrus]

ci/hydra-build:x86_64-darwin.mithril-signer failed again, with the same error message. Could it be my fault? 🤔 I'll try to run it locally on my MacBook.

[michalrus]

I was able to reproduce this failure locally on an x86_64-darwin:

❯ nix build --fallback -L .#hydraJobs.x86_64-darwin.mithril-signer

[…]

   Compiling mithril-signer v0.2.173 (/private/tmp/nix-build-mithril-signer-0.2.173.drv-0/source/mithril-signer)

[…]

    Finished `release` profile [optimized] target(s) in 55.52s
     Running `/private/tmp/nix-build-mithril-signer-0.2.173.drv-0/source/target/release/deps/mithril_signer-ffb4edaeea67228b`
<jemalloc>: Error allocating TSD
error: test failed, to rerun pass `-p mithril-signer --lib`

Caused by:
  process didn't exit successfully: `/private/tmp/nix-build-mithril-signer-0.2.173.drv-0/source/target/release/deps/mithril_signer-ffb4edaeea67228b` (signal: 6, SIGABRT: process abort signal)

I'm not sure how to proceed, @jpraynaud, @Alenar. 🤔

[jpraynaud]

ci/hydra-build:x86_64-darwin.mithril-signer failed again, with the same error message. Could it be my fault? 🤔 I'll try to run it locally on my MacBook.

There is some flakiness on the Hydra CI sometimes, but it's not related to your PR which doesn't modify the mithril-signer 👍

We're good to merge now, thanks again @michalrus!