Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance upgrade dependency runbook #1926

Merged
merged 4 commits into from
Sep 9, 2024
Merged

Enhance upgrade dependency runbook #1926

merged 4 commits into from
Sep 9, 2024

Conversation

Alenar
Copy link
Collaborator

@Alenar Alenar commented Sep 9, 2024

Content

This PR includes several improvements for the upgrade dependencies runbook and its associated script:

  • Add a cargo update step to update the Cargo.lock
  • Enable Nix flake.lock update step as the upgrade incompatibility have been circumvented in Update dependencies for release 2437 #1919
  • Fix the script path being incorrect in the runbook readme.
  • Fix the upgrade script missing the execute permission
  • Fix several typos

Pre-submit checklist

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)

jpraynaud
jpraynaud approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dlachaume
dlachaume approved these changes Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@dlachaume dlachaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 9, 2024

Test Results

    4 files  ±0     53 suites  ±0   9m 8s ⏱️ -23s
1 247 tests ±0  1 247 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 458 runs  ±0  1 458 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit ac379b1. ± Comparison against base commit 8690abe.

@Alenar Alenar temporarily deployed to testing-preview September 9, 2024 13:55 — with GitHub Actions Inactive
@Alenar Alenar temporarily deployed to testing-sanchonet September 9, 2024 13:55 — with GitHub Actions Inactive
@Alenar Alenar merged commit 0007402 into main Sep 9, 2024
39 checks passed
@Alenar Alenar deleted the djo/enhance-upgrade-dep-run-book branch September 9, 2024 14:56
sfauvel
sfauvel reviewed Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@sfauvel sfauvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfauvel sfauvel sfauvel left review comments

@dlachaume dlachaume dlachaume approved these changes

@jpraynaud jpraynaud jpraynaud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Alenar @sfauvel @jpraynaud @dlachaume