Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor signer state machine #1931

Merged
merged 25 commits into from
Sep 19, 2024
Merged

Refactor signer state machine #1931

merged 25 commits into from
Sep 19, 2024

Commits on Sep 18, 2024

  1. feat: implement can_signer_sign_current_epoch in Signer Epoch service 

    Co-authored-by: Jean-Philippe Raynaud <jpraynaud@users.noreply.github.com>
Co-authored-by: Sébastien Fauvel <sfauvel@users.noreply.github.com>
    @dlachaume @jpraynaud @sfauvel
    3 people committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    3a8f75f View commit details
    Browse the repository at this point in the history

  2. fix: remove inform_epoch_settings not needed async

    @dlachaume @sfauvel
    dlachaume authored and sfauvel committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    e7f2021 View commit details
    Browse the repository at this point in the history

  3. refactor: split can_i_sign into can_sign_current_epoch and `can_s… 

    …ign_signed_entity_type`
    @dlachaume @sfauvel
    dlachaume authored and sfauvel committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    114c3bc View commit details
    Browse the repository at this point in the history

  4. feat: add new states ReadyToSign and RegisteredNotAbleToSign 

    Co-authored-by: Sébastien Fauvel <sfauvel@users.noreply.github.com>
    @dlachaume @sfauvel
    dlachaume and sfauvel committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    067dd75 View commit details
    Browse the repository at this point in the history

  5. feat: remove functions related to outdated states

    @dlachaume @sfauvel
    dlachaume authored and sfauvel committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    332c4d2 View commit details
    Browse the repository at this point in the history

  6. fix: handle the case when transitioning from 'ReadyToSign' to 'ReadyT… 

    …oSign' when the last signed entity type is the same as the one in the pending certificate.
    @dlachaume @sfauvel
    dlachaume authored and sfauvel committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    7c4a4ef View commit details
    Browse the repository at this point in the history

  7. refactor: simplify state machine unit tests 

    Co-authored-by: Sébastien Fauvel <sfauvel@users.noreply.github.com>
    @dlachaume @sfauvel
    dlachaume and sfauvel committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    2e34343 View commit details
    Browse the repository at this point in the history

  8. test: adapt signer integration tests with the new states and transiti… 

    …ons in the signer state machine
    @dlachaume @sfauvel
    dlachaume authored and sfauvel committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    7a54bbb View commit details
    Browse the repository at this point in the history

  9. test: refactor integration test to simplify understanding 

    Co-authored-by: Sébastien Fauvel <sfauvel@users.noreply.github.com>
    @dlachaume @sfauvel
    dlachaume and sfauvel committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    7f02cd8 View commit details
    Browse the repository at this point in the history

  10. feat: remove old states from signer state machine

    @dlachaume @sfauvel
    dlachaume authored and sfauvel committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    934b09f View commit details
    Browse the repository at this point in the history

  11. refactor: ReadyToSign state during state machine cycle

    @dlachaume @sfauvel
    dlachaume authored and sfauvel committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    3785e62 View commit details
    Browse the repository at this point in the history

  12. docs: update documentation with new signer state machine diagram

    @dlachaume @sfauvel
    dlachaume authored and sfauvel committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    adfed4e View commit details
    Browse the repository at this point in the history

  13. refactor: Simplify code

    @sfauvel
    sfauvel committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    b9862bd View commit details
    Browse the repository at this point in the history

  14. docs: resize state machine diagram

    @dlachaume @sfauvel
    dlachaume authored and sfauvel committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    baf5431 View commit details
    Browse the repository at this point in the history

  15. fix: reuse the epoch of previous state when transition from `ReadyToS… 

    …ign` to `ReadyToSign`
    @sfauvel
    sfauvel committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    d601fe9 View commit details
    Browse the repository at this point in the history

  16. docs: update signer state machine diagram with new ReadyToSign state … 

    …data
    @dlachaume @sfauvel
    dlachaume authored and sfauvel committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    07484fc View commit details
    Browse the repository at this point in the history

  17. refactor: extract a function to compute next state from ReadyToSign

    @sfauvel
    sfauvel committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    60402d7 View commit details
    Browse the repository at this point in the history

  18. test: Add tests on can_sign_current_epoch and `can_sign_signed_enti… 

    …ty_type`
    @sfauvel
    sfauvel committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    23111e8 View commit details
    Browse the repository at this point in the history

  19. refactor: renaming functions and add logs

    @sfauvel
    sfauvel committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    911388b View commit details
    Browse the repository at this point in the history

  20. refactor: Align the states case in logs

    @sfauvel
    sfauvel committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    8719f00 View commit details
    Browse the repository at this point in the history

  21. refactor: pass only signed_entity_type to `transition_from_ready_to… 

    …_sign_to_ready_to_sign`and not the certificate
    @sfauvel
    sfauvel committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    e7ee8a8 View commit details
    Browse the repository at this point in the history

  22. refacto: function renaming and clean imports

    @sfauvel
    sfauvel committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    c7ce4e3 View commit details
    Browse the repository at this point in the history

  23. fix: propagate function renaming to integration tests

    @sfauvel
    sfauvel committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    a135b26 View commit details
    Browse the repository at this point in the history

  24. Upgrade crate versions 

    * mithril-signer from `0.2.182` to `0.2.183`
    @sfauvel
    sfauvel committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    8ef6732 View commit details
    Browse the repository at this point in the history

  25. chore: reference the feature in the CHANGELOG

    @dlachaume
    dlachaume committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    a8a3b5e View commit details
    Browse the repository at this point in the history