-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance mithril-common
logging
#1940
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alenar
temporarily deployed
to
testing-preview
September 19, 2024 17:03
— with
GitHub Actions
Inactive
Alenar
temporarily deployed
to
testing-sanchonet
September 19, 2024 17:03
— with
GitHub Actions
Inactive
sfauvel
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Good job, that will help to filter logs
mithril-common/src/cardano_block_scanner/chain_reader_block_streamer.rs
Outdated
Show resolved
Hide resolved
jpraynaud
approved these changes
Sep 20, 2024
dlachaume
approved these changes
Sep 20, 2024
Alenar
temporarily deployed
to
testing-preview
September 20, 2024 11:05
— with
GitHub Actions
Inactive
Alenar
temporarily deployed
to
testing-sanchonet
September 20, 2024 11:05
— with
GitHub Actions
Inactive
As it was only used in tests for easy loger creation and we have since added tooling to create test loggers that don't use `slog_scope`.
…mithril-common` And remove prefixes in log since we have now the source.
Alenar
force-pushed
the
djo/refactor_common_logging
branch
from
September 20, 2024 12:39
ea9b965
to
8582a8c
Compare
Alenar
temporarily deployed
to
testing-preview
September 20, 2024 12:49
— with
GitHub Actions
Inactive
Alenar
temporarily deployed
to
testing-sanchonet
September 20, 2024 12:49
— with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR add a
src
tag with the component name on all components inmithril-common
that have a logger. This change allow us to remove all prefixes that were previously used to tag a log source.This have the added benefit to add the source component to logs that previously did not use prefixes.
IE a log that previously written like this:
Have their prefixes supersede by a
src
tag like this:And logs that did not use prefix now have the
src
tag to identify the source component, ie:Pre-submit checklist
Comments
Also this PR remove the dev dependency to
slog_scope
frommithril-common
has we now have test tools to construct Logger when a test need one.