Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ci: use matrix strategy for build & docker jobs #196

Merged
merged 2 commits into from
May 13, 2022
Merged

Conversation

Alenar
Copy link
Collaborator

@Alenar Alenar commented May 12, 2022

No description provided.

@Alenar Alenar requested review from jpraynaud, a user and ghubertpalo May 12, 2022 08:57
@Alenar
Copy link
Collaborator Author

Alenar commented May 12, 2022

Works fine, there's only one caveat: jobs can't depends on a specific matrix build, they can only depends on the whole matrix.
The only jobs impacted by this are the docker-mithril-xxx: previously they would be skip if their specific build job failed now they will be skip if any of the matrix build jobs has failed.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would suggest to check https://github.com/actions/upload-artifact for filter syntax and erroring when no artifact uploaded

@github-actions
Copy link

Unit Test Results

    6 files  ±0    15 suites  ±0   2m 17s ⏱️ -7s
103 tests ±0  103 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 90fd834. ± Comparison against base commit 9cfa79c.

@Alenar Alenar merged commit 2423d89 into main May 13, 2022
@Alenar Alenar deleted the djo/ci_matrix_build branch May 13, 2022 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants