Fix: add migration to resolve deserialization issue with cardano_transactions_signing_config
#1971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlachaume
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
dlachaume
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
sfauvel
approved these changes
Oct 1, 2024
dlachaume
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
dlachaume
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
jpraynaud
approved these changes
Oct 1, 2024
Comment on lines
582
to
588
| // Temporary fix, should be removed | ||
| // Replace empty JSON values '{}' injected with Migration #28 | ||
| let cardano_signing_config = self | ||
| .get_signed_entity_config()? | ||
| .cardano_transactions_signing_config; | ||
| #[allow(deprecated)] | ||
| epoch_settings_store.replace_cardano_signing_config_empty_values(cardano_signing_config)?; |
There was a problem hiding this comment.
Maybe you can put this code in a dedicated block or add new lines before/after?
Co-authored-by: Sébastien Fauvel <sfauvel@users.noreply.github.com>
Alenar
approved these changes
Oct 1, 2024
* mithril-aggregator from `0.5.71` to `0.5.72`
sfauvel
force-pushed
the
ensemble/fix-epoch-setting-migration
branch
from
8773712 to
0939f56
Compare
sfauvel
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
sfauvel
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR includes a fix for the issue introduced by the merged PR #1964, which added a migration to the
epoch_settingtable.The
cardano_transactions_signing_configcolumn had a JSON default value that was not deserializable byserde.This PR adds a new migration to correct this by providing a deserializable default value.
Error on
testing-previewaggregator:Pre-submit checklist
Issue(s)
Relates to #1924