Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: implement era switch in e2e tests #1974

Merged
merged 16 commits into from
Oct 10, 2024

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Oct 2, 2024

Content

This pull request introduces several changes to the mithril-test-lab to support era switching and re-genesis processes. Key changes include updates to the CI workflow, enhancements to various scripts, and modifications to the end-to-end tests to handle new era transitions.

CI Workflow Enhancements:

  • Added next_era parameter to the matrix in .github/workflows/ci.yml to support testing era switches.
  • Included tests for era switch without regenesis and era switch with regenesis in .github/workflows/ci.yml.
  • Updated the command to include --mithril-next-era in .github/workflows/ci.yml.

Mithril Test Lab Enhancements:

  • Modified mkfiles-mithril-era.sh to compute and use the submitted transaction ID and handle UTxOs with and without inline datums. [1] [2] [3]
  • Updated exec.rs to include era_epoch in the register_era_marker function and improved logging. [1] [2]
  • Enhanced end_to_end_spec.rs to verify artifact production and handle era switches with optional regenesis. [1] [2] [3]
  • Added new command line arguments in main.rs to support mithril_next_era and mithril_era_regenesis_on_switch. [1] [2]
  • Updated aggregator.rs to handle era epochs and generate transaction data accordingly. [1] [2] [3]
  • Enhanced infrastructure.rs to manage era switches, including startup era registration and directory management per era. [1] [2] [3] [4] [5] [6] [7]

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Relates to #1946

@jpraynaud jpraynaud self-assigned this Oct 2, 2024
Copy link

github-actions bot commented Oct 2, 2024

Test Results

    4 files  ±0     54 suites  ±0   9m 29s ⏱️ +3s
1 338 tests ±0  1 338 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 546 runs  ±0  1 546 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit d3fe03f. ± Comparison against base commit 6849c3a.

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud force-pushed the jpraynaud/1946-era-switch-e2e-tests branch from f467324 to ab71ad3 Compare October 2, 2024 15:10
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet October 2, 2024 15:18 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/1946-era-switch-e2e-tests branch 2 times, most recently from 53465b6 to bb64f0c Compare October 2, 2024 15:36
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet October 2, 2024 15:44 — with GitHub Actions Inactive
@jpraynaud jpraynaud marked this pull request as ready for review October 9, 2024 08:47
@jpraynaud jpraynaud force-pushed the jpraynaud/1946-era-switch-e2e-tests branch from bb64f0c to 69e06b5 Compare October 9, 2024 09:03
@jpraynaud jpraynaud requested review from sfauvel and dlachaume October 9, 2024 09:03
@jpraynaud jpraynaud force-pushed the jpraynaud/1946-era-switch-e2e-tests branch 2 times, most recently from 56ef86d to 546f75b Compare October 9, 2024 09:40
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet October 9, 2024 09:48 — with GitHub Actions Inactive
Copy link
Collaborator

@dlachaume dlachaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@jpraynaud jpraynaud requested a review from Alenar October 9, 2024 12:46
@jpraynaud jpraynaud force-pushed the jpraynaud/1946-era-switch-e2e-tests branch 3 times, most recently from 1346239 to 1fa8c53 Compare October 9, 2024 15:42
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet October 9, 2024 15:52 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/1946-era-switch-e2e-tests branch from ff6db41 to 877e740 Compare October 9, 2024 15:58
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet October 9, 2024 16:06 — with GitHub Actions Inactive
Copy link
Collaborator

@sfauvel sfauvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Alenar Alenar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I left a few comments and suggestions.

@jpraynaud jpraynaud temporarily deployed to testing-sanchonet October 10, 2024 07:37 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/1946-era-switch-e2e-tests branch from 652ed07 to 047d5c2 Compare October 10, 2024 09:04
@jpraynaud jpraynaud force-pushed the jpraynaud/1946-era-switch-e2e-tests branch from 047d5c2 to d3fe03f Compare October 10, 2024 09:06
@jpraynaud jpraynaud temporarily deployed to testing-sanchonet October 10, 2024 09:21 — with GitHub Actions Inactive
@jpraynaud jpraynaud merged commit 03aa794 into main Oct 10, 2024
48 of 49 checks passed
@jpraynaud jpraynaud deleted the jpraynaud/1946-era-switch-e2e-tests branch October 10, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants