Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add real key registration to Mithril Aggregator and Mithril Signer #198

Merged
merged 13 commits into from
May 17, 2022
Merged

Add real key registration to Mithril Aggregator and Mithril Signer #198

merged 13 commits into from
May 17, 2022

Conversation

jpraynaud
Copy link
Member

Relates to #176

@jpraynaud jpraynaud force-pushed the jpraynaud/176-add-real-key-registration branch from 8e765de to a61277a Compare May 12, 2022 12:35
@github-actions
Copy link

github-actions bot commented May 12, 2022 •
edited
Loading

Unit Test Results

    6 files  ±  0    15 suites  ±0   2m 33s ⏱️ -14s
120 tests +13  120 ✔️ +13  0 💤 ±0  0 ❌ ±0 

Results for commit 0684448. ± Comparison against base commit 03e0875.

This pull request removes 2 and adds 15 tests. Note that renamed tests count towards both. 
http_server::tests ‑ test_certificate_pending_get_ko
http_server::tests ‑ test_register_signatures_post_ko

certificate_handler::tests ‑ test_register_signer_ok_201
certificate_handler::tests ‑ test_register_signer_ok_400
certificate_handler::tests ‑ test_register_signer_ok_409
certificate_handler::tests ‑ test_register_signer_ok_500
crypto_helper::types::tests ‑ test_protocol_parameters_from_into
http_server::tests ‑ test_certificate_pending_get_ko_current_beacon_500
http_server::tests ‑ test_certificate_pending_get_ko_protocol_parameters_500
http_server::tests ‑ test_certificate_pending_get_ko_signers_500
http_server::tests ‑ test_register_signatures_post_ko_400
http_server::tests ‑ test_register_signatures_post_ko_409
…

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud force-pushed the jpraynaud/176-add-real-key-registration branch 3 times, most recently from 0f506cc to f5cb6ee Compare May 16, 2022 17:37
@jpraynaud jpraynaud marked this pull request as ready for review May 16, 2022 17:51
@jpraynaud jpraynaud requested review from Alenar, a user and ghubertpalo May 16, 2022 17:51
@jpraynaud jpraynaud force-pushed the jpraynaud/176-add-real-key-registration branch from f5cb6ee to 0684448 Compare May 17, 2022 16:24
@jpraynaud jpraynaud merged commit fe4010b into main May 17, 2022
@jpraynaud jpraynaud deleted the jpraynaud/176-add-real-key-registration branch May 17, 2022 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alenar Alenar Awaiting requested review from Alenar

@ghubertpalo ghubertpalo Awaiting requested review from ghubertpalo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jpraynaud