Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize /register-signer route by replacing ticker service with epoch service #1991

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Optimize /register-signer route by replacing ticker service with epoch service #1991

merged 2 commits into from
Oct 10, 2024

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Oct 9, 2024 •
edited
Loading

Content

This PR includes the following changes to improve throughput in the /register-signer route:

  • Replaces direct calls to the chain observer (via the ticker service) with calls to the epoch service.
  • Removes the with_ticker_service middleware since it's not used anymore.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Closes #1982

@dlachaume dlachaume self-assigned this Oct 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 9, 2024 •
edited
Loading

Test Results

    4 files  ±0     54 suites  ±0   9m 2s ⏱️ -14s
1 332 tests +2  1 332 ✅ +2  0 💤 ±0  0 ❌ ±0 
1 540 runs  +2  1 540 ✅ +2  0 💤 ±0  0 ❌ ±0 

Results for commit 84f7ab2. ± Comparison against base commit 3c7fdab.

♻️ This comment has been updated with latest results.

@dlachaume dlachaume temporarily deployed to testing-sanchonet October 9, 2024 10:18 — with GitHub Actions Inactive
jpraynaud
jpraynaud approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

sfauvel
sfauvel approved these changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@sfauvel sfauvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dlachaume dlachaume force-pushed the dlachaume/1982/remove-chain-calls-from-register-signer-route branch from 7ae28e2 to 84f7ab2 Compare October 10, 2024 07:46
@dlachaume dlachaume temporarily deployed to testing-sanchonet October 10, 2024 07:57 — with GitHub Actions Inactive
@dlachaume dlachaume merged commit ae674b6 into main Oct 10, 2024
43 checks passed
@dlachaume dlachaume deleted the dlachaume/1982/remove-chain-calls-from-register-signer-route branch October 10, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpraynaud jpraynaud jpraynaud approved these changes

@sfauvel sfauvel sfauvel approved these changes

@Alenar Alenar Alenar approved these changes

Assignees

@dlachaume dlachaume

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove chain calls from register-signer route
4 participants
@dlachaume @Alenar @sfauvel @jpraynaud