Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: update dependencies runbook and script #2008

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Oct 14, 2024

Content

This PR includes a fix to the steps in the Upgrade the project's dependencies in the repository runbook and the associated script upgrade_dependencies.sh:

  • Reorder steps to compile mithril-client-wasm crate before updating the explorer
  • Remove from the script the npm package version bump (in /mithril-client-wasm/pkg file) for mithril-client-wasm

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

@dlachaume dlachaume self-assigned this Oct 14, 2024
Copy link

github-actions bot commented Oct 14, 2024

Test Results

    4 files  ±0     54 suites  ±0   9m 24s ⏱️ -1s
1 352 tests ±0  1 352 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 560 runs  ±0  1 560 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit fb3a449. ± Comparison against base commit 47cdaea.

♻️ This comment has been updated with latest results.

@dlachaume dlachaume temporarily deployed to testing-sanchonet October 14, 2024 14:56 — with GitHub Actions Inactive
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dlachaume dlachaume force-pushed the dlachaume/fix-upgrade-dependencies-runbook branch from 072cf68 to fb3a449 Compare October 15, 2024 07:24
@dlachaume dlachaume temporarily deployed to testing-sanchonet October 15, 2024 07:45 — with GitHub Actions Inactive
@dlachaume dlachaume merged commit 7c077cb into main Oct 15, 2024
48 checks passed
@dlachaume dlachaume deleted the dlachaume/fix-upgrade-dependencies-runbook branch October 15, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants