Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devbook: upgrade crates and openapi script #2042

Merged
merged 3 commits into from
Oct 23, 2024

Conversation

Alenar
Copy link
Collaborator

@Alenar Alenar commented Oct 22, 2024

Content

This PR introduce the devbook: a collection of useful scripts and procedures for Mithril developers.

In this devbook you will find:

  • upgrade-repository-dependencies, moved from the runbook since it's more of dev than a run operation
  • upgrade-crates-and-openapi-version: a new script to easily upgrade all crates versions + the openapi version that are changed in a PR compared to origin/main.

Pre-submit checklist

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)

@Alenar Alenar self-assigned this Oct 22, 2024
Copy link

github-actions bot commented Oct 22, 2024

Test Results

    4 files  ±0     55 suites  ±0   10m 27s ⏱️ -1s
1 395 tests ±0  1 395 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 609 runs  ±0  1 609 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit bd83d07. ± Comparison against base commit 0cbc482.

♻️ This comment has been updated with latest results.

Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

docs/devbook/README.md Outdated Show resolved Hide resolved
docs/devbook/upgrade-crates-and-openapi-versions/README.md Outdated Show resolved Hide resolved
docs/devbook/upgrade-crates-and-openapi-versions/README.md Outdated Show resolved Hide resolved
docs/devbook/upgrade-crates-and-openapi-versions/README.md Outdated Show resolved Hide resolved
docs/devbook/upgrade-crates-and-openapi-versions/README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@dlachaume dlachaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Alenar Alenar force-pushed the djo/devbook/upgrade_crates_and_open_api_script branch 4 times, most recently from 69eb763 to 4056a7a Compare October 23, 2024 09:56
@Alenar Alenar force-pushed the djo/devbook/upgrade_crates_and_open_api_script branch from 4056a7a to bd83d07 Compare October 23, 2024 09:59
@Alenar Alenar temporarily deployed to testing-preview October 23, 2024 10:09 — with GitHub Actions Inactive
@Alenar Alenar temporarily deployed to testing-sanchonet October 23, 2024 10:09 — with GitHub Actions Inactive
@Alenar Alenar merged commit 38b3203 into main Oct 23, 2024
45 checks passed
@Alenar Alenar deleted the djo/devbook/upgrade_crates_and_open_api_script branch October 23, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants