Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix metrics_per_day view and improve test by building the real Metric… #2068

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Fix metrics_per_day view and improve test by building the real Metric… #2068

merged 2 commits into from
Oct 31, 2024

Conversation

sfauvel
Copy link
Collaborator

@sfauvel sfauvel commented Oct 31, 2024 •
edited
Loading

Content

Fix the metrics_per_day view in monitoring database.
Improve test on this view by using the real MetricEventMessage json.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Relates to #2023

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 31, 2024 •
edited
Loading

Test Results

    4 files  ±0     51 suites  ±0   10m 41s ⏱️ +19s
1 418 tests ±0  1 418 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 629 runs  ±0  1 629 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit d91a2c6. ± Comparison against base commit 215620c.

♻️ This comment has been updated with latest results.

@sfauvel sfauvel temporarily deployed to testing-preview October 31, 2024 11:26 — with GitHub Actions Inactive
@sfauvel sfauvel temporarily deployed to testing-sanchonet October 31, 2024 11:26 — with GitHub Actions Inactive
@sfauvel sfauvel marked this pull request as ready for review October 31, 2024 11:31
jpraynaud
jpraynaud approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

dlachaume
dlachaume approved these changes Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@dlachaume dlachaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sfauvel sfauvel force-pushed the sfauvel/2023/fix_metrics_per_day_view branch from b77559c to 1bf4b97 Compare October 31, 2024 13:44
@sfauvel sfauvel temporarily deployed to testing-preview October 31, 2024 13:52 — with GitHub Actions Inactive
@sfauvel sfauvel temporarily deployed to testing-sanchonet October 31, 2024 13:52 — with GitHub Actions Inactive
@sfauvel
chore: upgrade crate versions
d91a2c6 
* mithril-aggregator from `0.5.96` to `0.5.97`
@sfauvel sfauvel force-pushed the sfauvel/2023/fix_metrics_per_day_view branch from 1bf4b97 to d91a2c6 Compare October 31, 2024 14:05
@sfauvel sfauvel temporarily deployed to testing-preview October 31, 2024 14:16 — with GitHub Actions Inactive
@sfauvel sfauvel temporarily deployed to testing-sanchonet October 31, 2024 14:16 — with GitHub Actions Inactive
@sfauvel sfauvel merged commit 3af8a57 into main Oct 31, 2024
50 checks passed
@sfauvel sfauvel deleted the sfauvel/2023/fix_metrics_per_day_view branch October 31, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlachaume dlachaume dlachaume approved these changes

@jpraynaud jpraynaud jpraynaud approved these changes

@Alenar Alenar Alenar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfauvel @Alenar @jpraynaud @dlachaume