-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add build target nodejs #2082
chore: add build target nodejs #2082
Conversation
Hi @fabianbormann, thanks for creating this PR. It will require some more work to implement a NodeJS compatible npm package for the Mithri client WASM. |
@fabianbormann can you sign your commits as it is mandatory for merging on this repository? |
Sure will do |
f5ad231
to
0ff64a9
Compare
@jpraynaud I signed the commit ✅ |
Hi @fabianbormann, I see that the branch has conflicts and can not be merged as is. |
@jpraynaud I'm done with resolving the conflicts 😊 |
@fabianbormann I think something is wrong with all these conflicts that should not be happening in the branch. There should be only 2 commits in this branch:
I think that you should do the following to get the PR ready to be merged:
|
03dda9c
to
c789b56
Compare
I don't know what went wrong, but after throwing the branch away and adding the line again it looks better now |
All good now 🎉 Once the CI run is green, I will merge the PR. |
Dear Mithril-team,
we need a commonjs package to run the mithril-client-wasm module within our ibc gateway setup.
Would it be possible to bundle the module for the nodejs target as well and publishing it within your pipeline to the npm package regsitry? I added the needed line to your Makefile.
Thanks for your support and keep up the great work ! 💪
Fabian