Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not add unfollow files when commit with upgrade_crates_and_openapi_versions.sh #2088

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Do not add unfollow files when commit with upgrade_crates_and_openapi_versions.sh #2088

merged 1 commit into from
Nov 5, 2024

Conversation

sfauvel
Copy link
Collaborator

@sfauvel sfauvel commented Nov 5, 2024 •
edited
Loading

Content

Add --update git option to not commit unfollow files.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

@sfauvel sfauvel marked this pull request as ready for review November 5, 2024 16:35
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024

Test Results

    4 files  ±0     51 suites  ±0   10m 38s ⏱️ +7s
1 423 tests ±0  1 423 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 634 runs  ±0  1 634 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit cf13db2. ± Comparison against base commit d1cf625.

@sfauvel sfauvel temporarily deployed to testing-preview November 5, 2024 16:42 — with GitHub Actions Inactive
@sfauvel sfauvel temporarily deployed to testing-sanchonet November 5, 2024 16:42 — with GitHub Actions Inactive
dlachaume
dlachaume approved these changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@dlachaume dlachaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfauvel sfauvel merged commit adce1f2 into main Nov 5, 2024
47 checks passed
@sfauvel sfauvel deleted the sfa/fix_upgrade_crates_script branch November 5, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlachaume dlachaume dlachaume approved these changes

@jpraynaud jpraynaud jpraynaud approved these changes

@Alenar Alenar Alenar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfauvel @Alenar @jpraynaud @dlachaume