Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor aggregator pruning with upkeep service #2103

Merged
merged 6 commits into from
Nov 12, 2024
Merged

Refactor aggregator pruning with upkeep service #2103

merged 6 commits into from
Nov 12, 2024

Conversation

sfauvel
Copy link
Collaborator

@sfauvel sfauvel commented Nov 8, 2024 •
edited
Loading

Content

This PR remove the pruning from the save function and use the upkeep service instead.
The EpochPruningTask is implemented in the Aggregator for the StakePoolStore and EpochSettingsStore

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Comments

Issue(s)

Relates to #2075

@sfauvel sfauvel force-pushed the sfa/2075/refactor_pruning_with_upkeep_service branch from c66d1b8 to 44a4cfb Compare November 8, 2024 16:37
@sfauvel sfauvel force-pushed the sfa/2075/refactor_pruning_with_upkeep_service branch from 44a4cfb to e4ee45b Compare November 8, 2024 16:45
@sfauvel sfauvel marked this pull request as ready for review November 8, 2024 16:48
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2024 •
edited
Loading

Test Results

    4 files  ±0     51 suites  ±0   11m 9s ⏱️ +3s
1 441 tests +4  1 441 ✅ +4  0 💤 ±0  0 ❌ ±0 
1 652 runs  +4  1 652 ✅ +4  0 💤 ±0  0 ❌ ±0 

Results for commit ef8feb1. ± Comparison against base commit c936b60.

♻️ This comment has been updated with latest results.

@sfauvel sfauvel temporarily deployed to testing-preview November 8, 2024 16:54 — with GitHub Actions Inactive
@sfauvel sfauvel temporarily deployed to testing-sanchonet November 8, 2024 16:54 — with GitHub Actions Inactive
@sfauvel sfauvel force-pushed the sfa/2075/refactor_pruning_with_upkeep_service branch from e4ee45b to 2f1f5dd Compare November 12, 2024 08:27
@sfauvel sfauvel temporarily deployed to testing-sanchonet November 12, 2024 08:35 — with GitHub Actions Inactive
@sfauvel sfauvel changed the title Refactor pruning with upkeep service Refactor aggregator pruning with upkeep service Nov 12, 2024
dlachaume
dlachaume approved these changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@dlachaume dlachaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

internal/mithril-persistence/src/sqlite/connection_extensions.rs Outdated Show resolved Hide resolved
internal/mithril-persistence/src/sqlite/connection_extensions.rs Show resolved Hide resolved
@sfauvel sfauvel force-pushed the sfa/2075/refactor_pruning_with_upkeep_service branch from 2f1f5dd to f313498 Compare November 12, 2024 11:08
@sfauvel sfauvel temporarily deployed to testing-sanchonet November 12, 2024 11:16 — with GitHub Actions Inactive
jpraynaud
jpraynaud approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sfauvel sfauvel force-pushed the sfa/2075/refactor_pruning_with_upkeep_service branch from f313498 to ef8feb1 Compare November 12, 2024 13:36
@sfauvel sfauvel temporarily deployed to testing-sanchonet November 12, 2024 13:44 — with GitHub Actions Inactive
@sfauvel sfauvel merged commit 0a7fb9f into main Nov 12, 2024
48 checks passed
@sfauvel sfauvel deleted the sfa/2075/refactor_pruning_with_upkeep_service branch November 12, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlachaume dlachaume dlachaume approved these changes

@jpraynaud jpraynaud jpraynaud approved these changes

@Alenar Alenar Awaiting requested review from Alenar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfauvel @jpraynaud @dlachaume