Fix for Failing STM Proptests #2125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curiecrypt
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
curiecrypt
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
Alenar
approved these changes
Nov 18, 2024
dlachaume
approved these changes
Nov 18, 2024
sfauvel
approved these changes
Nov 18, 2024
- 'mithril-stm' from '0.3.31' to '0.3.32'.
jpraynaud
force-pushed
the
curiecrypt/flaky-proptests
branch
from
c318955 to
414527f
Compare
jpraynaud
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
jpraynaud
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
For two different random configurations of the STM property test
batch_verify, in one iteration of each batch, not enough unique signatures were collected to meet the quorum. This caused the batch verification functionality test to fail intermittently, leading to flaky CI behavior.This PR updates the STM parameters for this test to ensure the quorum is always met, enabling consistent testing of batch verification functionality.
Pre-submit checklist
Issue(s)
Closes #2109