Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ci): include explorer in packaged releases #2167

Merged
merged 1 commit into from
Dec 11, 2024
Merged

feat(ci): include explorer in packaged releases #2167

merged 1 commit into from
Dec 11, 2024

Conversation

Alenar
Copy link
Collaborator

@Alenar Alenar commented Dec 11, 2024 •
edited
Loading

Content

This PR add to our nightly releases (and, since we promote them, to other releases) the packaged Explorer.

This will allow to have two explorer: one based on the latest released stable and one based on the latest nightly.

Pre-submit checklist

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@Alenar Alenar marked this pull request as ready for review December 11, 2024 09:00
@Alenar Alenar self-assigned this Dec 11, 2024
jpraynaud
jpraynaud approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link

Test Results

    4 files  ±0     52 suites  ±0   9m 44s ⏱️ -6s
1 429 tests ±0  1 429 ✅ ±0  0 💤 ±0  0 ❌ ±0 
1 640 runs  ±0  1 640 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit e5f1628. ± Comparison against base commit c6c7eba.

@Alenar Alenar temporarily deployed to testing-preview December 11, 2024 09:07 — with GitHub Actions Inactive
@Alenar Alenar temporarily deployed to testing-sanchonet December 11, 2024 09:07 — with GitHub Actions Inactive
@Alenar Alenar merged commit 5adc62c into main Dec 11, 2024
51 of 58 checks passed
@Alenar Alenar deleted the djo/package-explorer-in-releases branch December 11, 2024 09:09
@Alenar Alenar mentioned this pull request Dec 11, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlachaume dlachaume dlachaume approved these changes

@jpraynaud jpraynaud jpraynaud approved these changes

@sfauvel sfauvel sfauvel approved these changes

Assignees

@Alenar Alenar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Alenar @sfauvel @jpraynaud @dlachaume