Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signer signs real digest #219

Merged
merged 5 commits into from
May 31, 2022
Merged

Signer signs real digest #219

merged 5 commits into from
May 31, 2022

Conversation

Alenar
Copy link
Collaborator

@Alenar Alenar commented May 30, 2022

see #178

@Alenar Alenar requested review from jpraynaud and ghubertpalo May 30, 2022 11:01
@Alenar Alenar force-pushed the djo/178-signer-signs-real-digest branch from 3856c86 to bf26e51 Compare May 30, 2022 11:03
@github-actions
Copy link

github-actions bot commented May 30, 2022 •
edited
Loading

Unit Test Results

    5 files  ±0    14 suites  ±0   2m 23s ⏱️ -25s
159 tests +1  159 ✔️ +1  0 💤 ±0  0 ❌ ±0 

Results for commit 1121849. ± Comparison against base commit c5de621.

This pull request removes 7 and adds 8 tests. Note that renamed tests count towards both. 
signer::tests ‑ signer_does_not_send_signatures_if_none_are_computed
signer::tests ‑ signer_doesnt_sign_when_there_is_no_pending_certificate
signer::tests ‑ signer_fails_if_signature_computation_fails
signer::tests ‑ signer_fails_when_pending_certificate_fails
signer::tests ‑ signer_fails_when_register_signer_fails
signer::tests ‑ signer_sign_only_once_if_pending_certificate_has_not_changed
signer::tests ‑ signer_sign_when_triggered_by_pending_certificate

runtime::tests ‑ signer_does_not_send_signatures_if_none_are_computed
runtime::tests ‑ signer_doesnt_sign_when_there_is_no_pending_certificate
runtime::tests ‑ signer_fails_if_digest_computation_fails
runtime::tests ‑ signer_fails_if_signature_computation_fails
runtime::tests ‑ signer_fails_when_pending_certificate_fails
runtime::tests ‑ signer_fails_when_register_signer_fails
runtime::tests ‑ signer_sign_only_once_if_pending_certificate_has_not_changed
runtime::tests ‑ signer_sign_when_triggered_by_pending_certificate

♻️ This comment has been updated with latest results.

@Alenar Alenar force-pushed the djo/178-signer-signs-real-digest branch 2 times, most recently from 3d7d771 to cc93482 Compare May 30, 2022 12:31
jpraynaud
jpraynaud approved these changes May 30, 2022
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Alenar Alenar force-pushed the djo/178-signer-signs-real-digest branch 2 times, most recently from ec71b77 to 3a4935e Compare May 30, 2022 15:53
Alenar added 5 commits May 31, 2022 09:55
@Alenar
Signer: Add db_directory & rename Signer struct to Runtime
e85c879 
Signed-off-by: DJO <790521+Alenar@users.noreply.github.com>
@Alenar
Signer: split the runtime run methods in severals parts
f8bdfdf 
Signed-off-by: DJO <790521+Alenar@users.noreply.github.com>
@Alenar
Signer: add digester as a dependency to its runtime
3ae33ce 
Signed-off-by: DJO <790521+Alenar@users.noreply.github.com>
@Alenar
Signer signs local snapshots #178
d3e60a3 
Signed-off-by: DJO <790521+Alenar@users.noreply.github.com>
@Alenar
Aggregator signs real digest
1121849 
Signed-off-by: DJO <790521+Alenar@users.noreply.github.com>
@Alenar Alenar force-pushed the djo/178-signer-signs-real-digest branch from 1b3004b to 1121849 Compare May 31, 2022 07:55
jpraynaud
jpraynaud approved these changes May 31, 2022
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Alenar Alenar merged commit 1be5c35 into main May 31, 2022
@Alenar Alenar deleted the djo/178-signer-signs-real-digest branch May 31, 2022 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghubertpalo ghubertpalo ghubertpalo approved these changes

@jpraynaud jpraynaud jpraynaud approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Alenar @jpraynaud @ghubertpalo