Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Greg/runtime state machine #261

Merged
merged 18 commits into from
Jun 16, 2022
Merged

Greg/runtime state machine #261

merged 18 commits into from
Jun 16, 2022

Conversation

ghubertpalo
Copy link
Collaborator

This PR implements a state machine in aggregator's runtime.

@ghubertpalo ghubertpalo requested review from jpraynaud and Alenar June 14, 2022 15:04
@github-actions
Copy link

github-actions bot commented Jun 14, 2022 •
edited
Loading

Unit Test Results

205 tests  +1   205 ✔️ +1   7m 30s ⏱️ +6s
  17 suites ±0       0 💤 ±0 
    6 files   ±0       0 ❌ ±0 

Results for commit 6e8d24a. ± Comparison against base commit e97f8e3.

♻️ This comment has been updated with latest results.

Alenar
Alenar requested changes Jun 14, 2022
View reviewed changes
mithril-aggregator/src/runtime/runner.rs Outdated Show resolved Hide resolved
mithril-aggregator/src/runtime/runner.rs Outdated Show resolved Hide resolved
mithril-aggregator/src/runtime/runner.rs Show resolved Hide resolved
jpraynaud
jpraynaud approved these changes Jun 15, 2022
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ghubertpalo ghubertpalo force-pushed the greg/runtime-state-machine branch from d847ac8 to ff0a5ff Compare June 15, 2022 12:47
@ghubertpalo ghubertpalo requested a review from Alenar June 15, 2022 12:50
@ghubertpalo ghubertpalo force-pushed the greg/runtime-state-machine branch from ff0a5ff to 6e8d24a Compare June 16, 2022 07:50
@ghubertpalo ghubertpalo merged commit f9a51d8 into main Jun 16, 2022
@ghubertpalo ghubertpalo deleted the greg/runtime-state-machine branch June 16, 2022 08:11
@ghubertpalo ghubertpalo mentioned this pull request Jun 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpraynaud jpraynaud jpraynaud approved these changes

@Alenar Alenar Alenar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ghubertpalo @Alenar @jpraynaud