Rollback non deterministic Verification Keys in Signer #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The computation was relying on wrong verification keys, and lead to a panic from 'mithril-core', that occurred because the protocol initializer used to create the clerk did not find its verification key in the Merkle tree.
jpraynaud
force-pushed
the
jpraynaud/362-rollback-non-deterministic-vk
branch
from
8d26d2e to
d16c933
Compare
Alenar
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements:
Protocol Initializerof the Signer (to non deterministic)Clerkin the Multi Signer of the AggregatorCloses #362
Relates to #396 and #397