Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align signer & aggregator state machines logs #486

Merged
merged 6 commits into from
Sep 8, 2022

Conversation

Alenar
Copy link
Collaborator

@Alenar Alenar commented Sep 7, 2022

With this PR logs from Signers & Aggregator state machines will use the same semantic.

I've a question: should we pass to info level all logs from the cycle methods of both state machines ? I think it would make sense to show what's happening without flooding the logs too much, else on info only level most logs would only be new cycle [...] current_state: [...].

@github-actions
Copy link

github-actions bot commented Sep 7, 2022

Unit Test Results

    7 files  ±0    22 suites  ±0   2m 7s ⏱️ ±0s
318 tests ±0  318 ✔️ ±0  0 💤 ±0  0 ±0 
319 runs  ±0  319 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 624731d. ± Comparison against base commit b2704e1.

♻️ This comment has been updated with latest results.

Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

mithril-aggregator/src/runtime/state_machine.rs Outdated Show resolved Hide resolved
mithril-aggregator/src/runtime/state_machine.rs Outdated Show resolved Hide resolved
mithril-aggregator/src/runtime/state_machine.rs Outdated Show resolved Hide resolved
@Alenar Alenar merged commit d1c90c4 into main Sep 8, 2022
@Alenar Alenar deleted the djo/unify_aggregator_signer_state_machine_logs branch September 8, 2022 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants