Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version information #553

Merged
merged 4 commits into from
Oct 21, 2022
Merged

Add version information #553

merged 4 commits into from
Oct 21, 2022

Conversation

ghubertpalo
Copy link
Collaborator

Content

This PR adds the -V|--version to CLI tools.
It also adds a software version in the API headers.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Comments

Issue(s)

Closes #541

Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

github-actions bot commented Oct 21, 2022

Unit Test Results

    7 files  ±0    22 suites  ±0   1m 36s ⏱️ -56s
334 tests ±0  334 ✔️ ±0  0 💤 ±0  0 ±0 
335 runs  ±0  335 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 6056fb7. ± Comparison against base commit 3955689.

♻️ This comment has been updated with latest results.

@ghubertpalo ghubertpalo merged commit 9355d03 into main Oct 21, 2022
@ghubertpalo ghubertpalo deleted the greg/541/version_api branch October 21, 2022 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get/Show current version on Mithril nodes cli / APIs
2 participants