Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable Aggregator snapshot bucket #570

Merged
merged 7 commits into from
Oct 25, 2022

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Oct 25, 2022

Content

This PR includes a configurable Snapshot Bucket Name for the Aggregator that is used by the GCPFileUploader.
This will be used when deploying to the testing, pre-release and release environments.

Pre-submit checklist

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update documentation website

Issue(s)

Relates to #542

@jpraynaud jpraynaud force-pushed the jpraynaud/542-configurable-gcp-bucket branch from c9df8f9 to 1edf48c Compare October 25, 2022 15:24
@github-actions
Copy link

github-actions bot commented Oct 25, 2022

Unit Test Results

    7 files  ±0    22 suites  ±0   2m 10s ⏱️ -1s
322 tests ±0  322 ✔️ ±0  0 💤 ±0  0 ±0 
323 runs  ±0  323 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 873f947. ± Comparison against base commit fec5db3.

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud force-pushed the jpraynaud/542-configurable-gcp-bucket branch from 77cbab9 to 873f947 Compare October 25, 2022 15:42
@jpraynaud jpraynaud merged commit b352101 into main Oct 25, 2022
@jpraynaud jpraynaud deleted the jpraynaud/542-configurable-gcp-bucket branch October 25, 2022 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants