Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Aggregator snapshot url #573

Merged
merged 1 commit into from
Oct 27, 2022
Merged

Fix Aggregator snapshot url #573

merged 1 commit into from
Oct 27, 2022

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Oct 27, 2022 •
edited
Loading

Content

This PR includes a fix to use the 'snapshot_bucket_name' instead of 'cardano-testnet' in snapshot url builder.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Relates to #542

@jpraynaud
Fix snapshot url
40033c3 
Use the 'snapshot_bucket_name' instead of 'cardao-testnet' in snapshot url builder.
@github-actions
Copy link

Unit Test Results

    3 files    28 suites   3m 4s ⏱️
322 tests 322 ✔️ 0 💤 0 ❌
375 runs  375 ✔️ 0 💤 0 ❌

Results for commit 40033c3.

@jpraynaud jpraynaud merged commit ce3d42d into main Oct 27, 2022
@jpraynaud jpraynaud deleted the jpraynaud/542-fix-snapshot-url branch October 27, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alenar Alenar Alenar approved these changes

@ghubertpalo ghubertpalo Awaiting requested review from ghubertpalo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpraynaud @Alenar