Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Mithril networks infra #584

Merged
merged 4 commits into from
Nov 21, 2022
Merged

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Nov 4, 2022

Content

This PR includes new features on the Mithril networks infrastructure:

  • Add a retention delay for the VM compute disk snasphots
  • Enhance the customization of VM boot disk
  • Allow to restore a VM from a snapshot
  • Add a light unverified signer type (working on the Aggregator Cardano node instead of its own)

Pre-submit checklist

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Comments

⚠️ this PR includes some breaking changes that could lead to data loss on the networks!
The modification of the boot disk involves a re-deployment via terraform.
In order to not lose data (to do on each Mithril network, i.e. testing-preview, pre-release-preview and preprod-preview:

  • Stop all the docker containers
  • Make manual snapshot of the data with gcloud command
  • Apply terraform new configuration
  • Restore the saved data in the /home/curry/data folder after mounting a temporary compute disk created from the snapshot on the VM
  • Restart docker containers
  • Run the workflows

Issue(s)

Relates to #542 and #500

@jpraynaud jpraynaud added the breaking-change 🔥 Contains a breaking change label Nov 4, 2022
@jpraynaud jpraynaud marked this pull request as draft November 4, 2022 17:28
@github-actions
Copy link

github-actions bot commented Nov 4, 2022

Unit Test Results

    3 files    28 suites   2m 57s ⏱️
326 tests 326 ✔️ 0 💤 0
379 runs  379 ✔️ 0 💤 0

Results for commit d4876ec.

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud temporarily deployed to testing-preview November 4, 2022 17:50 Inactive
@jpraynaud jpraynaud temporarily deployed to testing-preview November 4, 2022 18:24 Inactive
VM disk can be restored from image or from snapshot.
Warning: Manual snapshot/restore operation may be necessary for live
environments to avoid data loss (as terraform considers vm disk must be replaced).
This Mithril signer node does not connect to its own Cardano node,
but on the Mithril Aggregator node instead.
Add missing jq tool.
@jpraynaud jpraynaud force-pushed the jpraynaud/542-infra-enhancements branch from 6ba9b04 to d4876ec Compare November 15, 2022 19:25
@jpraynaud jpraynaud temporarily deployed to testing-preview November 15, 2022 19:41 Inactive
@jpraynaud jpraynaud marked this pull request as ready for review November 15, 2022 19:49
@jpraynaud jpraynaud merged commit 72a1f24 into main Nov 21, 2022
@jpraynaud jpraynaud deleted the jpraynaud/542-infra-enhancements branch November 21, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change 🔥 Contains a breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants