Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop quitting when version downgrade #608

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

ghubertpalo
Copy link
Collaborator

Content

Stop quitting the application when a version downgrade is detected. The problem with SemVer comparisons is that we added build information as suffix which do not compare well. This leads to application to quit event when no downgrade was made.

This PR includes...

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Comments

This is a temporary fix, 2 other PR are also coming to handle this nicely.

Issue(s)

Relates to #600 and Closes #603

@github-actions
Copy link

github-actions bot commented Nov 23, 2022

Unit Test Results

    3 files  ±0    28 suites  ±0   3m 0s ⏱️ -28s
335 tests ±0  335 ✔️ ±0  0 💤 ±0  0 ±0 
388 runs  ±0  388 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit fdf652e. ± Comparison against base commit 4c2fac1.

♻️ This comment has been updated with latest results.

@ghubertpalo ghubertpalo force-pushed the greg/603/remove_version_panic branch from b04f797 to fdf652e Compare November 23, 2022 09:13
@ghubertpalo ghubertpalo temporarily deployed to testing-preview November 23, 2022 09:20 Inactive
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ghubertpalo ghubertpalo merged commit e7b8860 into main Nov 23, 2022
@ghubertpalo ghubertpalo deleted the greg/603/remove_version_panic branch November 23, 2022 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Store migration process does not accept a newer version
2 participants