stop quitting when version downgrade #608
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
Stop quitting the application when a version downgrade is detected. The problem with SemVer comparisons is that we added build information as suffix which do not compare well. This leads to application to quit event when no downgrade was made.
This PR includes...
Pre-submit checklist
Comments
This is a temporary fix, 2 other PR are also coming to handle this nicely.
Issue(s)
Relates to #600 and Closes #603