Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make SQL entities to create their projection #625

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Conversation

ghubertpalo
Copy link
Collaborator

Content

This PR includes a code rework that remove the need of creating dedicated Projection structures that work always the same way. It makes SqLiteEntity to return the Projection that can hydrate them. This removes a good part of boilerplate to use Providers.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

@ghubertpalo ghubertpalo temporarily deployed to testing-preview November 29, 2022 16:34 Inactive
@github-actions
Copy link

Unit Test Results

    3 files    28 suites   2m 36s ⏱️
339 tests 339 ✔️ 0 💤 0
392 runs  392 ✔️ 0 💤 0

Results for commit c11aa24.

@ghubertpalo ghubertpalo merged commit 0b86b1c into main Nov 30, 2022
@ghubertpalo ghubertpalo deleted the greg/sqlite_refacto branch November 30, 2022 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants