Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove certificate creation responsability from the multi-signer #639

Merged
merged 6 commits into from
Dec 7, 2022

Conversation

Alenar
Copy link
Collaborator

@Alenar Alenar commented Dec 6, 2022

Content

This PR change the behavior of the aggregator by transferring the certificate creation from the multi-signer to the state machine.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Fix #638 that's part of #398

@github-actions
Copy link

github-actions bot commented Dec 6, 2022

Test Results

    3 files  ±0    28 suites  ±0   2m 36s ⏱️ -30s
341 tests +2  341 ✔️ +2  0 💤 ±0  0 ±0 
394 runs  +2  394 ✔️ +2  0 💤 ±0  0 ±0 

Results for commit a089b9d. ± Comparison against base commit e18920a.

This pull request removes 1 and adds 3 tests. Note that renamed tests count towards both.
runtime::runner::tests ‑ test_create_and_save_certificate_ko_epoch_gap
certificate_creator::tests ‑ test
runtime::runner::tests ‑ test_create_new_working_certificate
runtime::runner::tests ‑ test_create_new_working_certificate_ko_epoch_gap

♻️ This comment has been updated with latest results.

@Alenar Alenar temporarily deployed to testing-preview December 6, 2022 13:12 Inactive
@Alenar Alenar force-pushed the ensemble/simplify_multi_signer branch 2 times, most recently from 95f6153 to 439c704 Compare December 6, 2022 16:12
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Alenar Alenar force-pushed the ensemble/simplify_multi_signer branch from 439c704 to a089b9d Compare December 6, 2022 16:23
@Alenar Alenar marked this pull request as ready for review December 6, 2022 16:44
@Alenar Alenar temporarily deployed to testing-preview December 6, 2022 17:17 Inactive
@Alenar Alenar merged commit 822e86a into main Dec 7, 2022
@Alenar Alenar deleted the ensemble/simplify_multi_signer branch December 7, 2022 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract the Certificate creation from the multi-signer
2 participants