check API version #641
Merged
check API version #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghubertpalo
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
ghubertpalo
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
ghubertpalo
force-pushed
the
greg/633/api_version
branch
from
53d2936 to
dd0fb88
Compare
ghubertpalo
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
ghubertpalo
commented
Dec 14, 2022
| .with(warp::reply::with::headers(headers)) | ||
| } | ||
|
|
||
| /// API Version verification |
There was a problem hiding this comment.
change the comment according to what the function does
ghubertpalo
commented
Dec 14, 2022
| .untuple_one() | ||
| } | ||
|
|
||
| pub async fn handle_custom(reject: Rejection) -> Result<impl Reply, Rejection> { |
There was a problem hiding this comment.
handle custom rejection codes
ghubertpalo
commented
Dec 14, 2022
| .untuple_one() | ||
| } | ||
|
|
||
| pub async fn handle_custom(reject: Rejection) -> Result<impl Reply, Rejection> { |
There was a problem hiding this comment.
not need to be public
|
Catch the HTTP error in the signer and the client to display an according error message. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ghubertpalo
force-pushed
the
greg/633/api_version
branch
from
3984a08 to
12ff761
Compare
ghubertpalo
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
ghubertpalo
force-pushed
the
greg/633/api_version
branch
from
eab2576 to
b1504ae
Compare
ghubertpalo
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR adds an API version check when requesting the Aggregator. If the API version does not match, the HTTP call is rejected.
Pre-submit checklist
Comments
None
Issue(s)
Closes #633