Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove test lab monitor & aggregator-server #660

Merged
merged 1 commit into from
Dec 20, 2022
Merged

Remove test lab monitor & aggregator-server #660

merged 1 commit into from
Dec 20, 2022

Conversation

Alenar
Copy link
Collaborator

@Alenar Alenar commented Dec 16, 2022 •
edited
Loading

Content

This PR includes remove the monitor & aggregator-server from the test lab. Since no one can maintains them in the team right now and we don't compile/use it it's no better than dead code.

Pre-submit checklist

  • Branch
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Comments

Should we also delete the docs in mithril-test-lab/docs ?

Issue(s)

Closes #658

@Alenar
Remove test lab monitor & aggregator-server
3e99b54 
Since no one can maintains them in the team right now and we don't compile/use it
it's no better than dead code.
@github-actions
Copy link

Test Results

    3 files  ±0    28 suites  ±0   2m 27s ⏱️ -29s
344 tests ±0  344 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
397 runs  ±0  397 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 3e99b54. ± Comparison against base commit e6c1527.

@Alenar Alenar temporarily deployed to testing-preview December 16, 2022 17:24 — with GitHub Actions Inactive
@Alenar Alenar marked this pull request as ready for review December 19, 2022 15:06
jpraynaud
jpraynaud approved these changes Dec 20, 2022
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Alenar Alenar merged commit f188985 into main Dec 20, 2022
@Alenar Alenar deleted the djo/658/delete-testlab-monitor branch December 20, 2022 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpraynaud jpraynaud jpraynaud approved these changes

@ghubertpalo ghubertpalo Awaiting requested review from ghubertpalo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Delete test lab monitor
2 participants
@Alenar @jpraynaud