Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

689 Signer Register Message #691

Merged
merged 6 commits into from
Jan 18, 2023
Merged

689 Signer Register Message #691

merged 6 commits into from
Jan 18, 2023

Conversation

ghubertpalo
Copy link
Collaborator

@ghubertpalo ghubertpalo commented Jan 17, 2023 •
edited
Loading

Content

This PR includes a message type for signer registration requests with an adapter to cast this type from Signer type.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Closes #689

@github-actions
Copy link

github-actions bot commented Jan 17, 2023 •
edited
Loading

Test Results

    3 files  ±0    28 suites  ±0   6m 5s ⏱️ +37s
389 tests +3  389 ✔️ +3  0 💤 ±0  0 ❌ ±0 
450 runs  +3  450 ✔️ +3  0 💤 ±0  0 ❌ ±0 

Results for commit 3ea6b98. ± Comparison against base commit f3107a5.

♻️ This comment has been updated with latest results.

@ghubertpalo ghubertpalo temporarily deployed to testing-preview January 18, 2023 09:28 — with GitHub Actions Inactive
@ghubertpalo ghubertpalo force-pushed the ensemble/689/signer_register_message branch from 6705434 to 9f985b5 Compare January 18, 2023 13:18
@ghubertpalo ghubertpalo marked this pull request as ready for review January 18, 2023 14:09
jpraynaud
jpraynaud approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ghubertpalo ghubertpalo force-pushed the ensemble/689/signer_register_message branch from e75ea23 to 3ea6b98 Compare January 18, 2023 14:29
@ghubertpalo ghubertpalo temporarily deployed to testing-preview January 18, 2023 14:39 — with GitHub Actions Inactive
@ghubertpalo ghubertpalo merged commit 16f62f7 into main Jan 18, 2023
@ghubertpalo ghubertpalo deleted the ensemble/689/signer_register_message branch January 18, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpraynaud jpraynaud jpraynaud approved these changes

@Alenar Alenar Alenar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement the mechanism for the signer registration
3 participants
@ghubertpalo @Alenar @jpraynaud