Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add certificate message and adapter #701

Merged
merged 7 commits into from
Jan 19, 2023

Conversation

jpraynaud
Copy link
Member

@jpraynaud jpraynaud commented Jan 19, 2023

Content

This PR adds a CertificateMessage message and adapter types.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

Issue(s)

Closes #697

@github-actions
Copy link

github-actions bot commented Jan 19, 2023

Test Results

    3 files  ±0    28 suites  ±0   5m 24s ⏱️ -29s
401 tests +3  401 ✔️ +3  0 💤 ±0  0 ±0 
466 runs  +5  466 ✔️ +5  0 💤 ±0  0 ±0 

Results for commit f8e7f44. ± Comparison against base commit 5679425.

This pull request removes 2 and adds 5 tests. Note that renamed tests count towards both.
message_adapters::to_register_signature_message_adapter::tests ‑ adapt_ok
message_adapters::to_register_signer_message_adapter::tests ‑ adapt_ok
message_adapters::from_certificate_message_adapter::tests ‑ adapt_ok
message_adapters::to_certificate_message::tests ‑ adapt_ok
message_adapters::to_register_signature_message::tests ‑ adapt_ok
message_adapters::to_register_signer_message::tests ‑ adapt_ok
messages::certificate::tests ‑ test_v1

♻️ This comment has been updated with latest results.

@jpraynaud jpraynaud temporarily deployed to testing-preview January 19, 2023 12:10 — with GitHub Actions Inactive
@jpraynaud jpraynaud self-assigned this Jan 19, 2023
@jpraynaud jpraynaud force-pushed the jpraynaud/697-add-certificate-message branch from e0db3ab to 8c25f64 Compare January 19, 2023 13:46
@jpraynaud jpraynaud temporarily deployed to testing-preview January 19, 2023 13:55 — with GitHub Actions Inactive
@jpraynaud jpraynaud force-pushed the jpraynaud/697-add-certificate-message branch from 8c25f64 to f8e7f44 Compare January 19, 2023 18:06
@jpraynaud jpraynaud temporarily deployed to testing-preview January 19, 2023 18:48 — with GitHub Actions Inactive
@jpraynaud jpraynaud merged commit 25f2d34 into main Jan 19, 2023
@jpraynaud jpraynaud deleted the jpraynaud/697-add-certificate-message branch January 19, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement the mechanism for certificate
2 participants